Create time syncronization protocol #7007
Open
+510
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzblue
reviewed
Aug 26, 2024
| [[format]] | ||
| === Message Format | ||
|
|
||
| TODO: Should I have an arbitrary magic value? do i need checksums? should we include a sequence number or other way to check if a message was replied to besides checking if we got the timestamp we expected back? |
There was a problem hiding this comment.
The client can treat the client timestamp as a sequence number if it's monotonic
There was a problem hiding this comment.
Implemented using this, and having the client throw out all pongs that don't match the currently active ping. This does mean that if you send pings faster than the server can handle, you might just never get your reply back since it'll get swapped out, which isn't great.
|
We need to be careful about using kernel timestamping- it uses the system clock, which can jump forward and backwards if the time is adjusted (e.g. on initial DS connection) |
|
Yeah, it might be best to drop that feature for now. |
mcm001
commented
Aug 28, 2024
mcm001
commented
Aug 28, 2024
mcm001
commented
Aug 28, 2024
mcm001
changed the title
Co-authored-by: Jade <[email protected]>
Co-authored-by: Joseph Eng <[email protected]>
mcm001
force-pushed
the
mmorley/20240825_tsp_adoc
branch
from
8c13a38
to
3d870ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very rough first pass at splitting the time sync requirements out into their own UDP thing. Putting this up early with a bunch of todos for visibility and to solicit feedback